netdev
[Top] [All Lists]

Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set
From: Neil Horman <nhorman@xxxxxxxxxx>
Date: Tue, 29 Mar 2005 16:29:49 -0500
Cc: Neil Horman <nhorman@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1112131560.1079.115.camel@jzny.localdomain>
References: <20050329202506.GI22447@hmsendeavour.rdu.redhat.com> <1112130720.1076.112.camel@jzny.localdomain> <20050329211741.GL22447@hmsendeavour.rdu.redhat.com> <1112131560.1079.115.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, Mar 29, 2005 at 04:26:00PM -0500, jamal wrote:
> On Tue, 2005-03-29 at 16:17, Neil Horman wrote:
> 
> > No worries.  What exactly is the point of contention on netdev? (I'm not
> > currently following that list).  My patch seems to follow the common 
> > practice
> > for CONFIG_NET_CLS_ACT, in that all references to the action member of the
> > appropriate struct are themselves ifdef-ed.
> 
> We are trying to kill appearance of any #ifdef CONFIG_NET_CLS_ACT in the
> classifiers. The patch you sent is correct except it will introduce
> an ifdef that we are trying to kill. The current workaround is to turn
> on CONFIG_NET_CLS_ACT in the kernel build.
> 
> cheers,
> jamal
> 
Gotcha.  That seems like a pretty good idea. :)  Thanks!
Neil

> 
> 

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@xxxxxxxxxx
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

<Prev in Thread] Current Thread [Next in Thread>