netdev
[Top] [All Lists]

2.4: [NETLINK] Fix bogus mc_list deletion

To: Tim Burress <tim@xxxxxxxxxxxxxxx>
Subject: 2.4: [NETLINK] Fix bogus mc_list deletion
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 29 Mar 2005 21:23:44 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx>
In-reply-to: <424937F1.30908@variosecure.net>
References: <424937F1.30908@variosecure.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Tue, Mar 29, 2005 at 08:11:45PM +0900, Tim Burress wrote:
> 
> So not only is the socket dead, it's not even a Netlink socket. 
> Apparently a socket originally allocated to Netlink was not unlinked 
> from the mc_list after it was freed, but offhand I can't see how that 
> could happen.

Thanks for tracking this issue down.

Looks like I made a nasty typo in the 2.4 backport.  When entries
are unlinked from mc_list, we link the list up with the regular
hash bucket list by using next instead of bind_next!

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Marcelo, you'll want this to be in the next rc.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>
  • 2.4: [NETLINK] Fix bogus mc_list deletion, Herbert Xu <=