Re: [PATCH] rtnl_unlock/lock in sch_api.c TRY2

[Thomas Graf <tgraf@xxxxxxx>]

* Catalin(ux aka Dino) BOIE 
<Pine.LNX.4.62.0503290206500.3229@xxxxxxxxxxxxxxxxxxx> 2005-03-29 02:09
> +     replay:
> +     tcm = NLMSG_DATA(n);
> +     tca = arg;
> +     clid = tcm->tcm_parent;

I know this has been in dave's patch already but why is this needed?
None of these variables changed in the meantime and the netlink message
should still be the same.

> +     q = p = NULL;

There is also no way for q being != NULL here but I don't mind
if this stays as-is, both are supposed to be temporary variables.

Despite of these two comments the patch looks ok to me.