Re: PATCH: action stats double dip

[Thomas Graf <tgraf@xxxxxxx>]

* jamal <1111768884.1092.533.camel@xxxxxxxxxxxxxxxx> 2005-03-25 11:41
>  
> -     if (tcf_exts_dump_stats(skb, &f->exts, &route_ext_map) < 0)
> -             goto rtattr_failure;
> +     if (f->exts.action && f->exts.action->type == TCA_OLD_COMPAT)
> +             if (tcf_exts_dump_stats(skb, &f->exts, &route_ext_map) < 0)
> +                     goto rtattr_failure;

Why is this needed? Maybe I'm missing something in the logic but
tcf_exts_dump_stats checks for exts->action and if in compat mode
provides the old stats TLVs. I'm not claiming that the current code
is correct but the fix should go into tcf_exts_dump_stats rather
than into every classifier.