| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [IPV4] Clear DF bit in ip_fragment fast path |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 23 Mar 2005 12:20:54 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20050321111637.GA24617@gondor.apana.org.au> |
| References: | <20050321105622.GA23809@gondor.apana.org.au> <20050321111637.GA24617@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 21 Mar 2005 22:16:37 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > It is possible for ip_fragment() to send out head fragments with > both DF and MF set for packets with local_df set to true. This is > because the fast path tries to only modify the MF bit of the head > fragment. > > Since the offset is always zero for the head fragment, and we know > that DF should be cleared in case of local_df, we can change |= to > a straight assignment. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Also applied, thanks Herbert. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [IPV4] Check mtu instead of frag_list in ip_push_pending_frames, David S. Miller |
|---|---|
| Next by Date: | [PATCH 2.6.12-rc1-mm1] net/ethernet/eth.c - eth_header, Vicente Feito |
| Previous by Thread: | [IPV4] Clear DF bit in ip_fragment fast path, Herbert Xu |
| Next by Thread: | Re: [IPV4] Check mtu instead of frag_list in ip_push_pending_frames, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |