| To: | yoshfuji@xxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] [NET] Save space for sk_alloc_slab() failure message. |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 17 Mar 2005 10:31:06 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20050318.033039.116005935.yoshfuji@linux-ipv6.org> |
| References: | <20050318.033039.116005935.yoshfuji@linux-ipv6.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 18 Mar 2005 03:30:39 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> wrote:
> (Almost) all callers of sk_alloc_slab() handle its failure like this:
>
> if (sk_alloc_slab(&prot, "sock")) {
> sk_alloc_slab_error(&prot); /* except for sctp */
> goto out;
> }
>
> So, why don't we move sk_alloc_slab_error() into sk_alloc_slab()
> for simplification and save text segment?
>
> Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
Looks great, patch applied.
Thanks.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] [NET] Save space for sk_alloc_slab() failure message., YOSHIFUJI Hideaki / 吉藤英明 |
|---|---|
| Next by Date: | [PATCH] net/socket.c : remove redundant NULL pointer check before kfree(), Jesper Juhl |
| Previous by Thread: | [PATCH] [NET] Save space for sk_alloc_slab() failure message., YOSHIFUJI Hideaki / 吉藤英明 |
| Next by Thread: | [PATCH] net/socket.c : remove redundant NULL pointer check before kfree(), Jesper Juhl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |