| To: | Chris Wedgwood <cw@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, Adam K Kirchhoff <adamk@xxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, Feyd <feyd@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Prism54-devel] Re: Problems with a PCI SMC2802W |
| From: | mcgrof@xxxxxxxxxxxxxxxxxx (Luis R. Rodriguez) |
| Date: | Wed, 16 Mar 2005 11:24:48 -0500 |
| In-reply-to: | <20050310163007.GK17854@ruslug.rutgers.edu> |
| Mail-followup-to: | Chris Wedgwood <cw@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, Adam K Kirchhoff <adamk@xxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, Feyd <feyd@xxxxxxxxx> |
| Organization: | Rutgers University Student Linux Users Group |
| References: | <422F118D.8070704@voicenet.com> <20050309160744.GN4017@Redstar.dorchain.net> <20050309202718.4f94b871@veagle.suse.cz> <20050310021724.GD17854@ruslug.rutgers.edu> <42302133.2060103@voicenet.com> <20050310103608.GB1416@taniwha.stupidest.org> <20050310163007.GK17854@ruslug.rutgers.edu> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
Jeff/netdev,
If no comment is given on how we should deal with
pci_dma_sync_single/pci_dma_sync_single_for_cpu for 2.4 I'm just going
to put in a nasty ifdef there. Comemnts?
Luis
On Thu, Mar 10, 2005 at 11:30:07AM -0500, Luis R. Rodriguez wrote:
> > Index: ksrc/islpci_mgt.c
> > ===================================================================
> > --- ksrc/islpci_mgt.c (revision 528)
> > +++ ksrc/islpci_mgt.c (working copy)
> > @@ -345,7 +345,7 @@
> > }
> >
> > /* Ensure the results of device DMA are visible to the CPU. */
> > - pci_dma_sync_single(priv->pdev, buf->pci_addr,
> > + pci_dma_sync_single_for_cpu(priv->pdev, buf->pci_addr,
> > frag_len, PCI_DMA_FROMDEVICE);
> >
> > /* Perform endianess conversion for PIMFOR header in-place. */
>
> Thanks, but the pci_[restore|save]_state changes requires testing/backporting
> to 2.4.
> Same goes for pci_dma_sync_single_for_cpu(). We can macro this but ugh, it's
> just so
> horrible.
>
> Margit, where are you?
>
> Jeff, what's better a prismcompat24.h edit or a check for
> LINUX_VERSION_CODE here?
>
> Luis
>
> --
> GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
--
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [patch 2.6.11] e100: NAPI state machine fix, John W. Linville |
|---|---|
| Next by Date: | Re: [patch 13/13] WE-18 (aka WPA), Luis R. Rodriguez |
| Previous by Thread: | Re: [Prism54-devel] Re: Problems with a PCI SMC2802W, Luis R. Rodriguez |
| Next by Thread: | Re: [Prism54-devel] Re: Problems with a PCI SMC2802W, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |