netdev
[Top] [All Lists]

Re: [RFT 2/3] 8139cp: don't mix software and chip stats

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [RFT 2/3] 8139cp: don't mix software and chip stats
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 16 Mar 2005 15:46:15 -0800
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050316234202.GB27664@electric-eye.fr.zoreil.com>
Organization: Open Source Development Lab
References: <20050316150431.6888fe55@dxpl.pdx.osdl.net> <20050316234202.GB27664@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 17 Mar 2005 00:42:02 +0100
Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:

> Stephen Hemminger <shemminger@xxxxxxxx> :
> > The rx_frags statistic is a software statistic and not a hardware statistic
> > and it is pasted on to the end. Since the statistic is really a warning 
> > about
> > overlength frames, it shouldn't be in the ethtool stats.  
> > 
> > Francois, could you make sure 8169 and 8139cp report fragments the same way.
> 
> (not sure I understood the question)

I just want frag handling to be similar in both driver since they both
have the same underlying chipset.  The stats should be the same, and any error
recovery should be similar.

Longer term, maybe the "grand unified phy" theory will allow making one driver
with different PHY support.

<Prev in Thread] Current Thread [Next in Thread>