netdev
[Top] [All Lists]

Re: [PATCH] Optimize loopback stats

To: Nivedita Singhvi <niv@xxxxxxxxxx>
Subject: Re: [PATCH] Optimize loopback stats
From: Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>
Date: Tue, 15 Mar 2005 18:15:59 -0500
Cc: Christoph Lameter <clameter@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-netdev <netdev@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On 15-Mar-05 Nivedita Singhvi wrote:

> Chuck Ebbert wrote:
>
> >   This patch optimizes the loopback driver's statistics by using a single
> > counter for rx and tx stats instead of one for rx and one for tx.  It also
> > adds unlikely() to the test for TSO since it's no longer supported by 
> > default.
> > (Maybe the TSO code should be bracketed by "#if 0" ?)
>
> Hmm, some of us want those counters separate - if this is really
> needed, could it be a configurable option, please?

 But they _are_ separately reported -- get_stats() takes care of that.
Everything looks exactly the same to userspace after this patch.




--
Chuck

<Prev in Thread] Current Thread [Next in Thread>