| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 05/13] remove last_rx update from loopback device |
| From: | Andrew Morton <akpm@xxxxxxxx> |
| Date: | Tue, 15 Mar 2005 15:08:09 -0800 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, christoph@xxxxxxxxxx, nirajk@xxxxxxxxxxxxxx, christoph@xxxxxxxxxxx, Shai@xxxxxxxxxxxx |
| In-reply-to: | <423764A3.8030201@pobox.com> |
| References: | <200503152222.j2FMMbhG016805@shell0.pdx.osdl.net> <423764A3.8030201@pobox.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > > > - dev->last_rx = jiffies; > > - > > lb_stats = &per_cpu(loopback_stats, get_cpu()); > > lb_stats->rx_bytes += skb->len; > > lb_stats->tx_bytes += skb->len; > > I disagree. loopback.c is doing precisely what it should be doing. Nothing actually seems to use last_rx? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch 05/13] remove last_rx update from loopback device, Jeff Garzik |
|---|---|
| Next by Date: | Re: [patch 04/13] e100: NAPI fixes, John W. Linville |
| Previous by Thread: | Re: [patch 05/13] remove last_rx update from loopback device, Jeff Garzik |
| Next by Thread: | Re: [patch 05/13] remove last_rx update from loopback device, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |