| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 15 Mar 2005 10:18:46 -0800 |
| Cc: | kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, kaber@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050315091904.GA6256@gondor.apana.org.au> |
| References: | <20050214221006.GA18415@gondor.apana.org.au> <20050214221200.GA18465@gondor.apana.org.au> <20050214221433.GB18465@gondor.apana.org.au> <20050214221607.GC18465@gondor.apana.org.au> <20050306213214.7d8a143d.davem@davemloft.net> <20050307103536.GB7137@gondor.apana.org.au> <20050308102741.GA23468@gondor.apana.org.au> <20050314102614.GA9610@gondor.apana.org.au> <20050314105313.GA21001@gondor.apana.org.au> <20050314111002.GA29156@gondor.apana.org.au> <20050315091904.GA6256@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 15 Mar 2005 20:19:04 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > This patch fixes the IPsec overhead handling in ip_append_data and > ip6_append_data. As it is they assume that the IPsec overhead is > constant. This is not true as with ESP the IPsec overhead will vary > as the MTU varies. > > The result is that they may produce packets that will exceed the MTU > when ESP is used. Had it taken the trailer_len into account, it would > have produced packets less than the real MTU. > > By switching to dst_mtu we get the optimal result. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Looks nice. Applied, thanks Herbert. |
| Previous by Date: | Re: [2.6 patch] fix bridge <-> ATM compile error, Adrian Bunk |
|---|---|
| Next by Date: | Re: [16/*] [INET] Take IPsec overhead into account in tunnels, David S. Miller |
| Previous by Thread: | Re: [21/*] [IPv4] Fix MTU check in ipmr_queue_xmit, David S. Miller |
| Next by Thread: | Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |