netdev
[Top] [All Lists]

Re: [PATCH] Fix ax25_get_socket locking

To: Ralf Baechle DL5RB <ralf@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] Fix ax25_get_socket locking
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 14 Mar 2005 21:30:15 -0800
Cc: netdev@xxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx
In-reply-to: <20050314083744.GA12765@linux-mips.org>
References: <20050314083744.GA12765@linux-mips.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 14 Mar 2005 08:37:44 +0000
Ralf Baechle DL5RB <ralf@xxxxxxxxxxxxxx> wrote:

> In an attempt to return a locked socket ax25_get_socket() was calling
> lock_sock() with a spinlock held, bad idea.  Making matters worse it's
> only user is running in bottom half context resulting in a potencial
> attempt to sleep in bottom half context, so fix the locking there as well.

Looks fine.  Applied, thanks Ralf.

<Prev in Thread] Current Thread [Next in Thread>