Re: [ANNOUNCE] Experimental Driver for Neterion/S2io 10GbE Adapters

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Mon, 14 Mar 2005 12:22:51 -0800
"Alex Aizman" <alex@xxxxxxxxxxxx> wrote:

> For these reviewers who consider this a minus, we hope you will find the HAL
> code in full compliance with Linux guidelines (in fact, it was written by
> our Linux team). Performance-wise, there was no negative impact discovered
> either. Testing-wise, this HAL has undergone numerous stress, functional,
> and performance tests "under" different drivers on a variety of platforms.

So you wrote a non-HAL version of this driver and compared the
results?  Simply comparing against the existins s2io driver
does not count.

If you're simply comparing against s2io, and your driver is faster
than s2io is already, imagine how much faster it might be without
that HAL layer.

I totally reject this driver, HAL is unacceptable for in-tree drivers.
We've been over this a thousand times.