On Sat, Mar 12, 2005 at 01:00:37AM +0100, Patrick McHardy wrote:
>
> Thanks for tracking this down, we need to unlock the state before
> calling icmp_send(). This patch fixes it, it should apply to 2.6.10
> if you replace dst_mtu() by dst_pmtu() in the context.
Good catch. However let's try to avoid spreading lock/unlock calls
around if possible.
Since tunnel_check_size only looks at the state to determine whether
it's tunnel mode, it doesn't need to hold the lock at all.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|