| To: | "Michael Chan" <mchan@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: tg3 kernel oops when setting flow control while interface is down (2.6.10) |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 10 Mar 2005 19:45:21 -0800 |
| Cc: | d.willmann@xxxxxxxx, netdev@xxxxxxxxxxx, jluebbe@xxxxxxxxx, davem@xxxxxxxxxx |
| In-reply-to: | <B1508D50A0692F42B217C22C02D84972020F3DCE@NT-IRVA-0741.brcm.ad.broadcom.com> |
| References: | <B1508D50A0692F42B217C22C02D84972020F3DCE@NT-IRVA-0741.brcm.ad.broadcom.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 28 Feb 2005 09:26:25 -0800 "Michael Chan" <mchan@xxxxxxxxxxxx> wrote: > I think it is better to just set the PAUSE flags and return 0 if > !netif_running(). This way, the settings will take effect when the device is > subsequently brought up. Then arguably we should do the same for link settings too. His patch exactly makes pause parameter setting behave the same as we currently do for link settings, if the device is down or in low power PHY mode, we -EAGAIN error out. We have to decide driver-wide how we're going to handle this situation. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] [ATM]: [fore200e] rewrite to eliminate pci_find_device() but preserve sbus support, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH] NET/ROM locking, David S. Miller |
| Previous by Thread: | Re: [PATCH] [ATM]: [fore200e] rewrite to eliminate pci_find_device() but preserve sbus support, David S. Miller |
| Next by Thread: | Re: tg3 kernel oops when setting flow control while interface is down (2.6.10), David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |