netdev
[Top] [All Lists]

Re: [Patch] sctp: add receive buffer accounting to sctp (fwd)

To: nhorman@xxxxxxxxxx
Subject: Re: [Patch] sctp: add receive buffer accounting to sctp (fwd)
From: nhorman@xxxxxxxxxx
Date: Thu, 10 Mar 2005 10:43:42 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Sridhar Samudrala <sri@xxxxxxxxxx>, netdev@xxxxxxxxxxx, lksctp-developers@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20050310120803.GA6341@hmsendeavour.rdu.redhat.com>
References: <Pine.LNX.4.61.0503030027590.8076@localhost.localdomain> <20050309211632.6f70fe41.davem@davemloft.net> <20050310120803.GA6341@hmsendeavour.rdu.redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
Repost of my ealier rcvbuf patch.  No changes, but rediffed to apply cleanly to
the head of the bitkeeper tree.  Passes all lksctp regression tests

Signed-off-by: Neil Horman <nhorman@xxxxxxxxxx>

 input.c |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+)


--- linux-2.6-sctp/net/sctp/input.c.orig        2005-03-10 07:11:46.000000000 
-0500
+++ linux-2.6-sctp/net/sctp/input.c     2005-03-10 07:18:25.000000000 -0500
@@ -100,6 +100,21 @@
        return 0;
 }
 
+/* The free routine for skbuffs that sctp receives */
+static void sctp_rfree(struct sk_buff *skb)
+{
+       atomic_sub(sizeof(struct sctp_chunk),&skb->sk->sk_rmem_alloc);
+       sock_rfree(skb);
+}
+
+/* The ownership wrapper routine to do receive buffer accounting */
+static void sctp_rcv_set_owner_r(struct sk_buff *skb, struct sock *sk)
+{
+       skb_set_owner_r(skb,sk);
+       skb->destructor = sctp_rfree;
+       atomic_add(sizeof(struct sctp_chunk),&sk->sk_rmem_alloc);
+}
+
 /*
  * This is the routine which IP calls when receiving an SCTP packet.
  */
@@ -183,6 +198,11 @@
        rcvr = asoc ? &asoc->base : &ep->base;
        sk = rcvr->sk;
 
+       if ((sk) && (atomic_read(&sk->sk_rmem_alloc) >= sk->sk_rcvbuf)) {
+               goto discard_release;
+       }
+
+
        /* SCTP seems to always need a timestamp right now (FIXME) */
        if (skb->stamp.tv_sec == 0) {
                do_gettimeofday(&skb->stamp);
@@ -203,6 +223,8 @@
                goto discard_release;
        }
 
+       sctp_rcv_set_owner_r(skb,sk);
+
        /* Remember what endpoint is to handle this packet. */
        chunk->rcvr = rcvr;
 
-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@xxxxxxxxxx
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

Attachment: pgpQXKGLADVhu.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>