| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [XFRM]: Fix ICMP tempsel |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 9 Mar 2005 20:49:47 -0800 |
| Cc: | herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <4217266F.6090700@trash.net> |
| References: | <4217266F.6090700@trash.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 19 Feb 2005 12:43:43 +0100 Patrick McHardy <kaber@xxxxxxxxx> wrote: > The selector ports are initialized to fl_ip_sport/fl_ip_dport instead > of xfrm_flowi_sport(fl)/xfrm_flowi_dport(fl). This is wrong for ICMP, > type and code should be stored in sport and dport, in struct flowi both > are contained in fl_ip_sport. This resulted in a long thread, many newer versions of the patch trying to clean this up in other ways, but then we determined that this original patch was the best and safest fix for now. So I applied this first patch. Thanks everyone. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [IPV4] Make loopback idev stick around, David S. Miller |
|---|---|
| Next by Date: | Re: pppoe and receive checksum offload, David S. Miller |
| Previous by Thread: | Re: [IPV4] Make loopback idev stick around, David S. Miller |
| Next by Thread: | Re: pppoe and receive checksum offload, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |