| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [11/*] [NET] Move dst_release out of dst->ops->check |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 8 Mar 2005 21:27:41 +1100 |
| Cc: | kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050307103536.GB7137@gondor.apana.org.au> |
| References: | <20050214221006.GA18415@gondor.apana.org.au> <20050214221200.GA18465@gondor.apana.org.au> <20050214221433.GB18465@gondor.apana.org.au> <20050214221607.GC18465@gondor.apana.org.au> <20050306213214.7d8a143d.davem@davemloft.net> <20050307103536.GB7137@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Mon, Mar 07, 2005 at 09:35:36PM +1100, herbert wrote: > > Here's the patch to fix those two problems. Yes I know > my dst_check implementation is lame. I'll come back and > fix up all the dst_check functions by moving their dst_release > calls out. It proves that you were right in that IPv6 dst > leak thread :) As promised here is the patch that moves dst_release out of dst->ops->check. It bloats sk_dst_check/__sk_dst_check slightly but they're only used in a handful of places so it isn't too bad. I actually counted, it's about a few hundred bytes. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| Previous by Date: | Re: [PATCH][BLUETOOTH] kill bt_sock_alloc, Arnaldo Carvalho de Melo |
|---|---|
| Next by Date: | Re: [11/*] [NET] Move dst_release out of dst->ops->check, YOSHIFUJI Hideaki / 吉藤英明 |
| Previous by Thread: | Re: [9/*] [IPSEC] Check dst validity harder in xfrm_bundle_ok, David S. Miller |
| Next by Thread: | Re: [11/*] [NET] Move dst_release out of dst->ops->check, YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |