netdev
[Top] [All Lists]

Re: [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()

To: domen@xxxxxxxxxxxx
Subject: Re: [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()
From: mcgrof@xxxxxxxxxxxxxxxxxx (Luis R. Rodriguez)
Date: Mon, 7 Mar 2005 12:13:04 -0500
Cc: prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx, janitor@xxxxxxxxxxxxxx
In-reply-to: <20050306222352.514491EC90@trashy.coderock.org>
Mail-followup-to: domen@xxxxxxxxxxxx, prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx, janitor@xxxxxxxxxxxxxx
Organization: Rutgers University Student Linux Users Group
References: <20050306222352.514491EC90@trashy.coderock.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
Patch applied to prism54 latest svn tree, thanks

        Luis

On Sun, Mar 06, 2005 at 11:23:51PM +0100, domen@xxxxxxxxxxxx wrote:
> 
> 
> 
> 
> Use msleep() instead of schedule_timeout()
> to guarantee the task delays as expected. Also set_current_state() is
> inserted before schedule_timeout().
> 
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
> Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>
> ---
> 
> 
>  kj-domen/drivers/net/wireless/prism54/islpci_dev.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN 
> drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev
>  drivers/net/wireless/prism54/islpci_dev.c
> --- 
> kj/drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev
>        2005-03-05 16:09:30.000000000 +0100
> +++ kj-domen/drivers/net/wireless/prism54/islpci_dev.c        2005-03-05 
> 16:09:30.000000000 +0100
> @@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
>       wmb();
>  
>       /* wait a while for the device to reset */
> -     set_current_state(TASK_UNINTERRUPTIBLE);
> -     schedule_timeout(50*HZ/1000);
> +     msleep(50);
>  
>       return 0;
>  }
> _

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

Attachment: pgpl6zy63KDE3.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>