| To: | davem@xxxxxxxxxx |
|---|---|
| Subject: | [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code |
| From: | domen@xxxxxxxxxxxx |
| Date: | Sun, 06 Mar 2005 23:21:17 +0100 |
| Cc: | netdev@xxxxxxxxxxx, domen@xxxxxxxxxxxx, yrgrknmxpzlk@xxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
compile warning cleanup - handle copy_to/from_user error
returns
Signed-off-by: Stephen Biggs <yrgrknmxpzlk@xxxxxxxxx>
Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>
---
kj-domen/net/ipv6/ip6_flowlabel.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff -puN net/ipv6/ip6_flowlabel.c~return_code-net_ipv6_ip6_flowlabel
net/ipv6/ip6_flowlabel.c
--- kj/net/ipv6/ip6_flowlabel.c~return_code-net_ipv6_ip6_flowlabel
2005-03-05 16:13:10.000000000 +0100
+++ kj-domen/net/ipv6/ip6_flowlabel.c 2005-03-05 16:13:10.000000000 +0100
@@ -537,9 +537,13 @@ release:
goto done;
/* Do not check for fault */
- if (!freq.flr_label)
- copy_to_user(&((struct in6_flowlabel_req __user *)
optval)->flr_label,
- &fl->label, sizeof(fl->label));
+ if (!freq.flr_label) {
+ if (copy_to_user(&((struct in6_flowlabel_req __user
*)optval)->flr_label,
+ &fl->label, sizeof(fl->label))) {
+ err = -EFAULT;
+ goto done;
+ }
+ }
sfl1->fl = fl;
sfl1->next = np->ipv6_fl_list;
_
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [patch 3/5] net/svcsock: replace schedule_timeout() with msleep(), domen |
|---|---|
| Next by Date: | [patch 5/5] net/clnt: remove sleep_on*() usage, domen |
| Previous by Thread: | [patch 3/5] net/svcsock: replace schedule_timeout() with msleep(), domen |
| Next by Thread: | Re: [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code, YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |