| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Sun, 6 Mar 2005 21:35:02 -0800 |
| Cc: | kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050216110842.GA1024@gondor.apana.org.au> |
| References: | <20050214221006.GA18415@gondor.apana.org.au> <20050214221200.GA18465@gondor.apana.org.au> <20050214221433.GB18465@gondor.apana.org.au> <20050214221607.GC18465@gondor.apana.org.au> <20050216103744.GA476@gondor.apana.org.au> <20050216110842.GA1024@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 16 Feb 2005 22:08:42 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > Let's also fix IPsec PMTU storage. When we get an MTU update for an > xfrm_dst, it should be done to the top dst, not the bottom dst. > > For example, when we get a need-to-frag message for host C behind > a our IPsec peer B, we should be updating the dst entry for C and > not B as we do now. > > I've removed the boundary checks since the same checks are done > in ipv[46]/route.c already. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Applied, thanks Herbert. Note that sometimes it is better to replace an "unnecessary as determined by me" boundary check with a BUG() instead of outright removal. That way you get to test your assertion :) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [5/*] [IPSEC] Use dst_mtu in xfrm[46]_output, David S. Miller |
|---|---|
| Next by Date: | Re: [7/*] [IPSEC] Get metrics for xfrm_dst from top dst, David S. Miller |
| Previous by Thread: | Re: [5/*] [IPSEC] Use dst_mtu in xfrm[46]_output, David S. Miller |
| Next by Thread: | Re: [6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |