On Fri, Mar 04, 2005 at 12:33:19PM -0500, Jeff Garzik wrote:
> akpm@xxxxxxxx wrote:
> >From: Adrian Bunk <bunk@xxxxxxxxx>
> >
> >Some of the options that needlessly wrote in their help text which options
> >they do select (patch already sent) didn't obey the most important rule of
> >select
> >
> > If you select something, you have to ensure that the dependencies
> > of what you do select are fulfilled.
>
> >diff -puN net/ieee80211/Kconfig~fix-buggy-ieee80211_crypt_-selects
> >net/ieee80211/Kconfig
> >--- 25/net/ieee80211/Kconfig~fix-buggy-ieee80211_crypt_-selects 2005-02-28
> >14:49:54.000000000 -0800
> >+++ 25-akpm/net/ieee80211/Kconfig 2005-02-28 14:49:54.000000000 -0800
> >@@ -44,6 +44,7 @@ config IEEE80211_CRYPT_WEP
> > config IEEE80211_CRYPT_CCMP
> > tristate "IEEE 802.11i CCMP support"
> > depends on IEEE80211
> >+ select CRYPTO
> > select CRYPTO_AES
> > ---help---
> > Include software based cipher suites in support of IEEE 802.11i
> >@@ -56,6 +57,7 @@ config IEEE80211_CRYPT_CCMP
> > config IEEE80211_CRYPT_TKIP
> > tristate "IEEE 802.11i TKIP encryption"
> > depends on IEEE80211
> >+ select CRYPTO
> > select CRYPTO_MICHAEL_MIC
> > ---help---
>
>
> You are resending the old patch that is incorrect. We don't need
> multiple selects, CRYPTO_AES and CRYPTO_MICHAEL_MIC should pull things in.
As I already said, this implies that options like CRYPTO_AES and
CRYPTO_MICHAEL_MIC can no longer depend on CRYPTO.
It's possible to change the crypto options in a way that CRYPTO is
selected as required but no longer directly selectable (and I could send
such a patch), but that's a decision of the crypto maintainers.
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
|