| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (3/12) skge: remove unneeded include's |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Mar 2005 21:51:16 +0000 |
| Cc: | Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <42278470.2070807@pobox.com> |
| References: | <20050303113413.1bcd7476@dxpl.pdx.osdl.net> <42278470.2070807@pobox.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Thu, Mar 03, 2005 at 04:41:04PM -0500, Jeff Garzik wrote: > Stephen Hemminger wrote: > >Get rid of unnecessary include's > > > >Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx> > > > >--- skge-2.6.11/drivers/net/skge.c.orig 2005-03-02 > >17:15:44.000000000 -0800 > >+++ skge-2.6.11/drivers/net/skge.c 2005-03-02 17:17:25.000000000 -0800 > >@@ -30,13 +30,10 @@ > > #include <linux/moduleparam.h> > > #include <linux/netdevice.h> > > #include <linux/etherdevice.h> > >-#include <linux/dma-mapping.h> > > Why is this one is unnecessary? Becasue the driver is using the pci_ variants of the dma mapping routines, which are in pci.h |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: netif_rx packet dumping, Baruch Even |
|---|---|
| Next by Date: | Re: netif_rx packet dumping, Andi Kleen |
| Previous by Thread: | Re: [PATCH] (3/12) skge: remove unneeded include's, Jeff Garzik |
| Next by Thread: | [PATCH] (4/12) skge: suspend/resume related state management, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |