netdev
[Top] [All Lists]

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

To: Jeff Garzik <jgarzik@xxxxxxxxx>, jmorris@xxxxxxxxxx, davem@xxxxxxxxxxxxx
Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
From: Adrian Bunk <bunk@xxxxxxxxx>
Date: Wed, 2 Mar 2005 22:59:03 +0100
Cc: Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <42261004.4000501@pobox.com>
References: <20050223014233.6710fd73.akpm@osdl.org> <20050226113123.GJ3311@stusta.de> <42256078.1040002@pobox.com> <20050302140833.GD4608@stusta.de> <42261004.4000501@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Wed, Mar 02, 2005 at 02:12:04PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:
> >
> >>Adrian Bunk wrote:
> >>
> >>>+  select CRYPTO
> >>>   select CRYPTO_AES
> >>>   ---help---
> >>>   Include software based cipher suites in support of IEEE 802.11i 
> >>>   (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled 
> >>>   networks.
> >>>@@ -54,10 +55,11 @@
> >>>   "ieee80211_crypt_ccmp".
> >>>
> >>>config IEEE80211_CRYPT_TKIP
> >>>   tristate "IEEE 802.11i TKIP encryption"
> >>>   depends on IEEE80211
> >>>+  select CRYPTO
> >>>   select CRYPTO_MICHAEL_MIC
> >>
> >>
> >>'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.
> >
> >
> >This would result in a recursive dependency.
> 
> No, it wouldn't.  CRYPTO_AES depends on CRYPTO, which depends on nothing.

Exactly.

And if CRYPTO_AES would select CRYPTO, you'd have a recursive 
dependency.

The only possible thing would be to change all dependencies on CRYPTO to 
selects. This wouldn't be unlogical since the whole crypto subsystem is 
only a helper for other subsystems.

James, any opinions on this issue?

>       Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


<Prev in Thread] Current Thread [Next in Thread>