Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

[Andrew Morton <akpm@xxxxxxxx>]

Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> > Thing is, CRYPTO_AES on only selectable on x86.
> 
>  You're thinking about CRYPTO_AES_586.  But looking at crypto/Kconfig, 
>  the dependencies are a bit weird:
> 
>  config CRYPTO_AES
>           tristate "AES cipher algorithms"
>           depends on CRYPTO && !(X86 && !X86_64)
>  config CRYPTO_AES_586
>           tristate "AES cipher algorithms (i586)"
>           depends on CRYPTO && (X86 && !X86_64)

That's pretty broken, isn't it?

Would be better to just do:

config CRYPTO_AES
        select CRYPTO_AES_586 if (X86 && !X86_64)
        select CRYPTO_AES_OTHER if !(X86 && !X86_64)

and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world.