netdev
[Top] [All Lists]

Re: [PATCH] emac: filter illegal frame sizes

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] emac: filter illegal frame sizes
From: Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 2 Mar 2005 09:29:18 -0700
Cc: netdev@xxxxxxxxxxx, linuxppc-embedded@xxxxxxxxxx
In-reply-to: <4216FD64.9020509@pobox.com>; from jgarzik@pobox.com on Sat, Feb 19, 2005 at 03:48:36AM -0500
References: <20050218101245.D11439@cox.net> <4216FD64.9020509@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Sat, Feb 19, 2005 at 03:48:36AM -0500, Jeff Garzik wrote:
> Matt Porter wrote:
> > Fix to drop frames that are too large for the current MTU.
> 
> What is this fixing?
> 
> You should be passing all frames up to the software stack.

I was originally fixing the issue where the driver was only allocating
rx buffers big enough for the configured MTU and got a bit
overzealous. I pulled out the filtering hunks so we always allocate
skbs large enough to handle a full size jumbo frame and pass everything
up to the stack...new patch to follow.

-Matt

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] emac: filter illegal frame sizes, Matt Porter <=