Re: pppoe and receive checksum offload

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 28, 2005 at 10:31:06PM +1100, herbert wrote:
> 
> In fact it looks like the current code in ip_gre is broken
> in this respect as well.

Actually ip_gre is probably right.  It seems that CHECKSUM_UNNECESSARY
should not be set for PPPOE/GRE packets at all.  So it would be a bug in
the sk* driver.

Alexey/Dave, is this interpretation of ip_summed correct?

Of course we still need to fix up CHECKSUM_HW in pppoe.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt