netdev
[Top] [All Lists]

pppoe and receive checksum offload

To: "David S. Miller" <davem@xxxxxxxxxxxxx>, mostrows@xxxxxxxxxxxxx, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Subject: pppoe and receive checksum offload
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 24 Feb 2005 15:59:06 -0800
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
Someone reported a problem with skge hardware receive checksumming and PPPOE
but it looks like a generic problem.  Since PPPOE adds additional header
bytes the hardware computed checksum will be wrong.  

Not sure if this is correct, but shouldn't pppoe be doing the following:
-----
diff -Nru a/drivers/net/pppoe.c b/drivers/net/pppoe.c
--- a/drivers/net/pppoe.c       2005-02-24 15:40:10 -08:00
+++ b/drivers/net/pppoe.c       2005-02-24 15:40:10 -08:00
@@ -339,6 +339,7 @@
                int len = ntohs(ph->length);
                skb_pull(skb, sizeof(struct pppoe_hdr));
                skb_trim(skb, len);
+               skb->ip_summed = CHECKSUM_NONE;
 
                ppp_input(&po->chan, skb);
        } else if (sk->sk_state & PPPOX_RELAY) {

<Prev in Thread] Current Thread [Next in Thread>