netdev
[Top] [All Lists]

Re: Intel and TOE in the news

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: Intel and TOE in the news
From: Andi Kleen <ak@xxxxxx>
Date: 22 Feb 2005 19:07:11 +0100
Date: Tue, 22 Feb 2005 19:07:11 +0100
Cc: Leonid Grossman <leonid.grossman@xxxxxxxxxxxx>, hadi@xxxxxxxxxx, "'rick jones'" <rick.jones2@xxxxxx>, netdev@xxxxxxxxxxx, "'Alex Aizman'" <alex@xxxxxxxxxxxx>
In-reply-to: <20050222100227.7ea76f2c@dxpl.pdx.osdl.net>
References: <1109005880.1076.77.camel@jzny.localdomain> <200502211803.j1LI3cDD009072@guinness.s2io.com> <20050222100227.7ea76f2c@dxpl.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
> Be careful, this may have the same problems that original TSO code did.
> Make sure and force the PUSH flag on these jumbo receives or the TCP
> "every other segment" ACK logic will be busted.  There are other parts of TCP

> that depend on packet count as well and this inverse TSO logic will break 
> them.

Linux TCP RX path didn't care about PSH last time I checked. It should
make no difference how PSH is set on RX or if it is set at all. At least
unless Leonid wants to run his driver on Darwin too, but that would be 
someone else's problem.

-Andi

<Prev in Thread] Current Thread [Next in Thread>