| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [patch 2.6.11-rc4-netdev1 1/5] r8169: fix rx skb allocation error logging |
| From: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
| Date: | Tue, 22 Feb 2005 00:53:01 +0100 |
| Cc: | netdev@xxxxxxxxxxx, jdmason@xxxxxxxxxx |
| In-reply-to: | <20050221235125.GD26248@electric-eye.fr.zoreil.com> |
| References: | <20050221235125.GD26248@electric-eye.fr.zoreil.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
Fix rx skb allocation error logging
Signed arithmetic is not required as rtl8169_rx_fill() return belongs
to the [0; NUM_RX_DESC] interval.
Signed-off-by: Jon Mason <jdmason@xxxxxxxxxx>
Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
diff -puN drivers/net/r8169.c~r8169-400 drivers/net/r8169.c
--- a/drivers/net/r8169.c~r8169-400 2005-02-17 21:50:09.820173216 +0100
+++ b/drivers/net/r8169.c 2005-02-17 22:00:00.210450784 +0100
@@ -2156,8 +2156,8 @@ static int
rtl8169_rx_interrupt(struct net_device *dev, struct rtl8169_private *tp,
void __iomem *ioaddr)
{
- unsigned int cur_rx, rx_left, count;
- int delta;
+ unsigned int cur_rx, rx_left;
+ unsigned int delta, count;
assert(dev != NULL);
assert(tp != NULL);
@@ -2225,10 +2225,8 @@ rtl8169_rx_interrupt(struct net_device *
tp->cur_rx = cur_rx;
delta = rtl8169_rx_fill(tp, dev, tp->dirty_rx, tp->cur_rx);
- if (delta < 0) {
+ if (!delta && count)
printk(KERN_INFO "%s: no Rx buffer allocated\n", dev->name);
- delta = 0;
- }
tp->dirty_rx += delta;
/*
_
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [patch 2.6.11-rc4-netdev1 0/5] r8169: intro, Francois Romieu |
|---|---|
| Next by Date: | [patch 2.6.11-rc4-netdev1 2/5] r8169: skb alignment nitpicking, Francois Romieu |
| Previous by Thread: | [patch 2.6.11-rc4-netdev1 0/5] r8169: intro, Francois Romieu |
| Next by Thread: | [patch 2.6.11-rc4-netdev1 2/5] r8169: skb alignment nitpicking, Francois Romieu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |