netdev
[Top] [All Lists]

Re: 2.6.10 TCP troubles -- suggested patch

To: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Subject: Re: 2.6.10 TCP troubles -- suggested patch
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 16 Feb 2005 09:50:04 -0800
Cc: shemminger@xxxxxxxx, hubert.tonneau@xxxxxxxxxxxxxx, romieu@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, niv@xxxxxxxxxx, rick.jones2@xxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050216091323.GA26758@yakov.inr.ac.ru>
References: <0525M9211@server5.heliogroup.fr> <20050211150420.74737b2e@dxpl.pdx.osdl.net> <20050215152354.46a08d77.davem@davemloft.net> <20050216091323.GA26758@yakov.inr.ac.ru>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 16 Feb 2005 12:13:23 +0300
Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx> wrote:

> BTW it is still a puzzle why 2.6.9 works. With disabled TSO it should
> insert PSHs quite rarely, similarly to tso.

Yes.

Hubert, do you have netfilter enabled in the 2.6.10 kernel you are running?

I'm asking because the TCP changes in 2.6.10 are pretty benign
(attached for the curious who want to review along), whereas
netfilter had major updates particularly in the TCP connection
tracking code.

I also reviewed 2.6.10-ac11 for anything interesting wrt. TCP and the
only thing in there is the tcp_retrans_try_collapse() missing check
to avoid collapsing TSO segments.

Attachment: tcp-2.6.10
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>