Re: Fix fallout from tg3_readphy() value is zero on error

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Tue, 15 Feb 2005 10:18:14 -0800
"Michael Chan" <mchan@xxxxxxxxxxxx> wrote:

> > @@ -793,9 +799,11 @@
> >  
> >     tg3_writephy(tp, MII_TG3_CTRL, phy9_orig);
> >  
> > -   tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32);
> > -   reg32 &= ~0x3000;
> > -   tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32);
> > +   if (tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32)) {
> > +           reg32 &= ~0x3000;
> > +           tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32);
> > +   } else if (!err)
> > +           err = -EBUSY;
> >  
> >     return err;
> >  }
> 
> Shouldn't this be:
> 
> > +   if (!tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32)) {

Right, fixed in my local tree.

Thanks a lot.