Re: [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing when the device is closed

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
> [...]
> > @@ -2399,6 +2398,8 @@ static int rtl8169_close(struct net_devi
> >  
> >   free_irq(dev->irq, dev);
> >  
> > + netif_poll_enable(dev);
> > +
> >   pci_free_consistent(pdev, R8169_RX_RING_BYTES, tp->RxDescArray,
> >         tp->RxPhyAddr);
> >   pci_free_consistent(pdev, R8169_TX_RING_BYTES, tp->TxDescArray,
> > 
> > _
> 
> Dumb question....Why is this needed?  dev_close has already checked for the 

dev_open() after dev_close(): netif_rx_schedule_prep() always fails in
rtl8169_interrupt() and the device can not be scheduled for poll. Sucky.

So, if someone wants to push it before 2.6.11 goes out...

-- 
Ueimor