| To: | Pablo Neira <pablo@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] [NETLINK] fix broken indentation in netlink.h |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 10 Feb 2005 17:32:01 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <420BF8C3.3050305@eurodev.net> |
| References: | <420BF8C3.3050305@eurodev.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 11 Feb 2005 01:13:55 +0100 Pablo Neira <pablo@xxxxxxxxxxx> wrote: > the subject says all Don't split up lines like from: extern int func(...); into: extern int func(...); That's just gross and means that when I run grep on the tree I won't see the function's return type for hits, I'll only see the args. Just keep the long declarations. Why don't you bypass all the cleanup diffs and just do the functionality change instead? When you mix whitespace and coding style cleanups with real changes, it puts your real changes at risk if we think your cleanups are ugly or bogus since you've created a patch dependency. One thing at a time. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.10 TCP troubles -- suggested patch, David S. Miller |
|---|---|
| Next by Date: | Re: [Bugme-new] [Bug 4189] New: IPv6 link local addresses are not assigned correctly on multiple-bonding enviromrnts, Rick Jones |
| Previous by Thread: | [PATCH 1/4] [NETLINK] fix broken indentation in netlink.h, Pablo Neira |
| Next by Thread: | [PATCH] [NETLINK] unify checkings for clean messages, Pablo Neira |
| Indexes: | [Date] [Thread] [Top] [All Lists] |