netdev
[Top] [All Lists]

Re: [PATCH 1/4] [NETLINK] fix broken indentation in netlink.h

To: Pablo Neira <pablo@xxxxxxxxxxx>
Subject: Re: [PATCH 1/4] [NETLINK] fix broken indentation in netlink.h
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 10 Feb 2005 17:32:01 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <420BF8C3.3050305@eurodev.net>
References: <420BF8C3.3050305@eurodev.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 11 Feb 2005 01:13:55 +0100
Pablo Neira <pablo@xxxxxxxxxxx> wrote:

> the subject says all

Don't split up lines like from:

extern int func(...);

into:

extern int
func(...);

That's just gross and means that when I run grep on the tree I
won't see the function's return type for hits, I'll only see the
args.

Just keep the long declarations.

Why don't you bypass all the cleanup diffs and just do the functionality
change instead?  When you mix whitespace and coding style cleanups
with real changes, it puts your real changes at risk if we think your
cleanups are ugly or bogus since you've created a patch dependency.

One thing at a time.

<Prev in Thread] Current Thread [Next in Thread>