netdev
[Top] [All Lists]

Re: [2/2] [NET] Add skb_header_cloned and use it in e1000/tg3

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [2/2] [NET] Add skb_header_cloned and use it in e1000/tg3
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 8 Feb 2005 21:09:10 -0800
Cc: kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050129032210.GA7424@gondor.apana.org.au>
References: <20050121204024.6f94fc26.davem@davemloft.net> <20050122054346.GA1635@gondor.apana.org.au> <20050122170533.GB11499@yakov.inr.ac.ru> <20050123071027.GA20296@gondor.apana.org.au> <20050126110043.GA29950@yakov.inr.ac.ru> <20050126222522.GA21670@gondor.apana.org.au> <20050127110946.GA20494@gondor.apana.org.au> <20050127111201.GB20494@gondor.apana.org.au> <20050128202542.GA23670@yakov.inr.ac.ru> <20050129031740.GA6130@gondor.apana.org.au> <20050129032210.GA7424@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 29 Jan 2005 14:22:10 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> This patch adds skb_header_cloned which tells us whether we need to
> copy the data before we can modify the header part of the skb.  Again,
> what constitutes the header is left up to the users of the skb to define.
> 
> This patch then uses this function in e1000/tg3 to copy the data before
> the TCP/IP header is modified.
>  
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

These two patches look great.  I want to review them some more but
I do intend to try and get them into 2.6.11-final.

<Prev in Thread] Current Thread [Next in Thread>