netdev
[Top] [All Lists]

Re: [PATCH] ipconfig invokes undefined behaviour

To: Matthew Wilcox <matthew@xxxxxx>
Subject: Re: [PATCH] ipconfig invokes undefined behaviour
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Sun, 6 Feb 2005 22:45:40 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050206044744.GO20386@parcelfarce.linux.theplanet.co.uk>
References: <20050206044744.GO20386@parcelfarce.linux.theplanet.co.uk>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 6 Feb 2005 04:47:44 +0000
Matthew Wilcox <matthew@xxxxxx> wrote:

> strcpy is undefined if src and dest overlap.  That's clearly possible
> here with a sufficiently deep path on the server.  Use memmove instead.
> 
> Signed-off-by: Matthew Wilcox <matthew@xxxxxx>

Thanks a lot Matthew, applied to both 2.4.x and 2.6.x

<Prev in Thread] Current Thread [Next in Thread>