| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] netem: memory leak |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Fri, 4 Feb 2005 15:31:08 -0800 |
| Cc: | js si <nistnet_user@xxxxxxxxx>, netem@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050204231103.33325.qmail@web41510.mail.yahoo.com> |
| Organization: | Open Source Development Lab |
| References: | <20050204231103.33325.qmail@web41510.mail.yahoo.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Good catch.. netem needs to free skb's that are dropped due to loss
simulation.
diff -Nru a/net/sched/sch_netem.c b/net/sched/sch_netem.c
--- a/net/sched/sch_netem.c 2005-02-04 15:30:13 -08:00
+++ b/net/sched/sch_netem.c 2005-02-04 15:30:13 -08:00
@@ -177,6 +177,7 @@
if (q->loss && q->loss >= get_crandom(&q->loss_cor)) {
pr_debug("netem_enqueue: random loss\n");
sch->qstats.drops++;
+ kfree_skb(skb);
return 0; /* lie about loss so TCP doesn't know */
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] ieee80211 subsystem, Jeff Garzik |
|---|---|
| Next by Date: | Re: [PATCH] arp_queue: serializing unlink + kfree_skb, David S. Miller |
| Previous by Thread: | Re: [XFRM] Probe selected algorithm only, Andreas Schwab |
| Next by Thread: | Re: [PATCH] netem: memory leak, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |