Re: [PATCH 1/2] ipv4 routing: splitting of ip_route_[in|out]put_slow, 2.6.10-rc3

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Mon, 20 Dec 2004 12:13:24 +0100
Einar Lück <lkml@xxxxxxxxxxxxxx> wrote:

> This patch splits up ip_route_[in|out]put_slow in inlined functions.
> Basic idea:
> * improve overall comprehensibility
> * allow for an easier application of patch for improved multipath 
>   support

Patch applied to my 2.6.12 pending tree.  Thanks a lot Einar.

One minor comment is that there are some minor cases where
excessing in_dev get/put can be eliminated.  For example,
in __mkroute_output() we really only need to do the
in_dev_get(dev_out) once, yet we do it twice due to how
the return path of this function always puts the reference
even in the non-error case.