netdev
[Top] [All Lists]

[PATCH] prism54: use initialized current_time in debug_code

To: prism54-private@xxxxxxxxxxx
Subject: [PATCH] prism54: use initialized current_time in debug_code
From: Alexey Dobriyan <adobriyan@xxxxxxx>
Date: Wed, 2 Feb 2005 13:34:41 +0200
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.6.2
Otherwise gcc 4 complains:

drivers/net/wireless/prism54/isl_38xx.c: In function 
âisl38xx_trigger_deviceâ:
drivers/net/wireless/prism54/isl_38xx.c:131: warning: âcurrent_time.tv_secâ 
is used uninitialized in this function
drivers/net/wireless/prism54/isl_38xx.c:131: warning: 
âcurrent_time.tv_usecâ is used uninitialized in this function

Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxx>

--- linux-2.6.11-rc2-bk10/drivers/net/wireless/prism54/isl_38xx.c.orig  
2005-02-02 13:20:57.000000000 +0200
+++ linux-2.6.11-rc2-bk10/drivers/net/wireless/prism54/isl_38xx.c       
2005-02-02 13:24:25.000000000 +0200
@@ -112,7 +112,9 @@ isl38xx_handle_wakeup(isl38xx_control_bl
 void
 isl38xx_trigger_device(int asleep, void __iomem *device_base)
 {
+#if VERBOSE > SHOW_ERROR_MESSAGES
        struct timeval current_time;
+#endif
        u32 reg, counter = 0;
 
 #if VERBOSE > SHOW_ERROR_MESSAGES
@@ -126,11 +128,10 @@ isl38xx_trigger_device(int asleep, void 
                do_gettimeofday(&current_time);
                DEBUG(SHOW_TRACING, "%08li.%08li Device wakeup triggered\n",
                      current_time.tv_sec, current_time.tv_usec);
-#endif
-
                DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
                      current_time.tv_sec, current_time.tv_usec,
                      readl(device_base + ISL38XX_CTRL_STAT_REG));
+#endif
                udelay(ISL38XX_WRITEIO_DELAY);
 
                reg = readl(device_base + ISL38XX_INT_IDENT_REG);
@@ -148,10 +149,13 @@ isl38xx_trigger_device(int asleep, void 
                                counter++;
                        }
 
+#if VERBOSE > SHOW_ERROR_MESSAGES
+                       do_gettimeofday(&current_time);
                        DEBUG(SHOW_TRACING,
                              "%08li.%08li Device register read %08x\n",
                              current_time.tv_sec, current_time.tv_usec,
                              readl(device_base + ISL38XX_CTRL_STAT_REG));
+#endif
                        udelay(ISL38XX_WRITEIO_DELAY);
 
 #if VERBOSE > SHOW_ERROR_MESSAGES

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] prism54: use initialized current_time in debug_code, Alexey Dobriyan <=