netdev
[Top] [All Lists]

Re: [patch 2/2] ipvs deadlock fix

To: Horms <horms@xxxxxxxxxxxx>
Subject: Re: [patch 2/2] ipvs deadlock fix
From: Andrew Morton <akpm@xxxxxxxx>
Date: Mon, 31 Jan 2005 01:47:22 -0800
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050131093609.GA3804@verge.net.au>
References: <200501310633.j0V6X1l01385@mail.osdl.org> <20050131093609.GA3804@verge.net.au>
Sender: netdev-bounce@xxxxxxxxxxx
Horms <horms@xxxxxxxxxxxx> wrote:
>
> On Sun, Jan 30, 2005 at 10:33:02PM -0800, akpm@xxxxxxxx wrote:
>  > 
>  > 
>  > update_defense_level() is calling si_meminfo() from timer context.  But
>  > si_meminfo takes non-irq-safe locks.
>  > 
>  > Move it all to keventd context.  
> 
>  Would I be right in thinking that the offending lock is bdev_lock which
>  is grabbed in nr_blockdev_pages() and thus that this is not an issue
>  for 2.4 whose si_meminfo() does not have such a call?

Yes, 2.4's si_meminfo() seems to be OK from interrupt context.

On x86 - I didn't check the other architectures.

<Prev in Thread] Current Thread [Next in Thread>