| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: design for TSO performance fix |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Jan 2005 11:28:38 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20050128054441.GA8260@gondor.apana.org.au> |
| References: | <20050127163146.33b01e95.davem@davemloft.net> <E1CuKzJ-0001mY-00@gondolin.me.apana.org.au> <20050127211940.31f97ed3.davem@davemloft.net> <20050128054441.GA8260@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 28 Jan 2005 16:44:41 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > Colour me confused then. How are you going to remember the > packet boundaries which we need to do if we're going to keep > counting packets instead of bytes? It's just like how the code was before I added all of that tcp_pcount_t code. The retransmit queue only ever contains normal MSS sized frames. When we decide to send something off the queue, we try to build them up into TSO frames. Congestion control etc. decisions are still made by packet counting. When we get ACKs and SACKs back, we can just trim and mark the retransmit queue in the simplest way since we don't have TSO packets in there anymore. TSO packets only exist in the tcp_transmit_skb() path, nothing else in the stack sees them. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Bug in 2.6.10, Christian Schmid |
|---|---|
| Next by Date: | Re: design for TSO performance fix, David S. Miller |
| Previous by Thread: | Re: design for TSO performance fix, Herbert Xu |
| Next by Thread: | Re: design for TSO performance fix, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |