netdev
[Top] [All Lists]

Re: [PATCH 1/5] sis900 printk audit

To: Jeff Garzik <jgarzik@xxxxxxxxx>, NetDev <netdev@xxxxxxxxxxx>
Subject: Re: [PATCH 1/5] sis900 printk audit
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Sun, 23 Jan 2005 17:16:47 +0100
In-reply-to: <20050123085229.GD31816@gateway.milesteg.arr>
References: <20050122214657.18649.66345@localhost.localdomain> <20050122222640.GB24461@electric-eye.fr.zoreil.com> <20050123085229.GD31816@gateway.milesteg.arr>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Daniele Venzano <webvenza@xxxxxxxxx> :
[...]
> Is that a suggestion that I make some global variable or macro to avoid
> repeating that declaration in almost every function of the driver ?

It suggests turning:

        struct sis900_private *sis_priv = net_dev->priv;

into:

        struct sis900_private *sis_priv = netdev_priv(net_dev);

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>