netdev
[Top] [All Lists]

Re: [RFC 2.6.10 5/22] xfrm: Attempt to offload bundled xfrm_states for o

To: David Dillow <dave@xxxxxxxxxxxxxx>
Subject: Re: [RFC 2.6.10 5/22] xfrm: Attempt to offload bundled xfrm_states for outbound xfrms
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 21 Jan 2005 15:20:45 -0800
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dave@xxxxxxxxxxxxxx
In-reply-to: <20041230035000.14@ori.thedillows.org>
References: <20041230035000.13@ori.thedillows.org> <20041230035000.14@ori.thedillows.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 30 Dec 2004 03:48:35 -0500
David Dillow <dave@xxxxxxxxxxxxxx> wrote:

> +static void xfrm_accel_bundle(struct dst_entry *dst)
> +{
> +     struct xfrm_bundle_list bundle, *xbl, *tmp;
> +     struct net_device *dev = dst->dev;
> +     INIT_LIST_HEAD(&bundle.node);
> +
> +     if (dev && netif_running(dev) && (dev->features & NETIF_F_IPSEC)) {

netif_running() is only steady while the RTNL semaphore is held,
which is not necessarily true when xfrm_lookup() is invoked.

<Prev in Thread] Current Thread [Next in Thread>