netdev
[Top] [All Lists]

Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 18 Jan 2005 10:11:28 +1100
Cc: tommy.christensen@xxxxxxxxx, simon.roscic@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050117133640.0405d791.davem@davemloft.net>
References: <E1Cpo1q-0007lI-00@gondolin.me.apana.org.au> <41E942AF.3030202@tpack.net> <20050115183023.GA31211@gondor.apana.org.au> <41E97B1A.30205@tpack.net> <20050116080254.GA2997@gondor.apana.org.au> <20050117133640.0405d791.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Mon, Jan 17, 2005 at 01:36:40PM -0800, David S. Miller wrote:
> 
> I think this patch is buggy.  At least in the final hunk, we
> do this:
> 
>       info.skb = skb;
>       ...
>       skb = netlink_trim( ... );
> 
> Now info.skb can be pointing to a freed up skb.

Doh! Here is the corrected version.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks Dave.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>