Re: [DEBUG]: sk_forward_alloc assertion failures

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Jan 14, 2005 at 08:55:43PM -0800, David S. Miller wrote:
> 
> Doing the adjustments at tcp_write_xmit() time also runs into the
> problem you mentioned where we're just blindly subtracting from
> sk_forward_alloc.

Not really because what we're doing there is increasing sk_forward_alloc,
just as we do in tcp_trim_head.

Anyway, I'm not terribly attached to that idea since we're doing
a page's worth of data each time around the loop anyway so it's
not too bad.
 
> Here's a patch against current BK that tries to do that.  See any
> holes? :-)

Just one little problem :)

> +             if (sk->sk_forward_alloc < copy &&
> +                 !sk_stream_mem_schedule(sk, copy, 0))

You want to have sk->sk_allocation here instead of 0.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt