On Fri, Jan 14, 2005 at 02:04:26PM -0800, David S. Miller wrote:
>
> I see, but we don't want sendmsg() to charge a full MSS if the
> user is only writing 10 bytes of data onto the wire. That seems
> to be what happens if we implement things the way you are suggesting.
Yes you're right. Although I belive it only happens in the case of
sendpages(). It will allocate more memory than what's required in
that case. I'd say that it should be rare to have a 10 byte packet with
sendfile() though.
However, it's not all that difficult to fix up either. We can adjust
truesize to a more reasonable value in tcp_write_xmit(). Something
like this will do.
Actually it happens in the case of sendmsg() too. Unfortunately in
that case we can't do a thing about it since the memory is allocated
between skb->head and skb->tail.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|