netdev
[Top] [All Lists]

[patch 07/19] net/sir_dev: replace schedule_timeout() with msleep()

To: jgarzik@xxxxxxxxx
Subject: [patch 07/19] net/sir_dev: replace schedule_timeout() with msleep()
From: domen@xxxxxxxxxxxx
Date: Wed, 12 Jan 2005 00:10:27 +0100
Cc: netdev@xxxxxxxxxxx, domen@xxxxxxxxxxxx, nacc@xxxxxxxxxx, janitor@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx


Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>
---


 kj-domen/drivers/net/irda/sir_dev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/net/irda/sir_dev.c~msleep-drivers_net_irda_sir_dev 
drivers/net/irda/sir_dev.c
--- kj/drivers/net/irda/sir_dev.c~msleep-drivers_net_irda_sir_dev       
2005-01-10 18:00:01.000000000 +0100
+++ kj-domen/drivers/net/irda/sir_dev.c 2005-01-10 18:00:01.000000000 +0100
@@ -15,6 +15,7 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/smp_lock.h>
+#include <linux/delay.h>
 
 #include <net/irda/irda.h>
 #include <net/irda/wrapper.h>
@@ -73,8 +74,7 @@ int sirdev_raw_write(struct sir_dev *dev
        spin_lock_irqsave(&dev->tx_lock, flags);        /* serialize with other 
tx operations */
        while (dev->tx_buff.len > 0) {                  /* wait until tx idle */
                spin_unlock_irqrestore(&dev->tx_lock, flags);
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(msecs_to_jiffies(10));
+               msleep(10);
                spin_lock_irqsave(&dev->tx_lock, flags);
        }
 
_

<Prev in Thread] Current Thread [Next in Thread>
  • [patch 07/19] net/sir_dev: replace schedule_timeout() with msleep(), domen <=