netdev
[Top] [All Lists]

Re: [PATCH] /driver/net/wan/sbs520

To: Adam Anthony <AAnthony@xxxxxxx>
Subject: Re: [PATCH] /driver/net/wan/sbs520
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Mon, 10 Jan 2005 21:29:47 +0100
Cc: Matthias-Christian Ott <matthias.christian@xxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <4F23E557A0317D45864097982DE907941A3383@pilotmail.sbscorp.sbs.com>
References: <4F23E557A0317D45864097982DE907941A3383@pilotmail.sbscorp.sbs.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Adam Anthony <AAnthony@xxxxxxx> :
> Thank you for the heads up A&M.  I have destroyed the evil [^M]'s, and
> updated the package.
> http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download

o OsMapPhysToVirt
  -> should be ioremap/pci_iomap()

o OsUnMapVirt
  -> iounmap, etc.

o OsAllocateNonPagedMemory/OsMemcpy/OsStall/OsSleep/OsZeroMem
  -> useless wrappers.

o OsAllocateDeviceMemory
  Yuck, virt_to_bus !
  Please read:
  - linux-2.6.x/Documentation/DMA-mapping.txt
  - linux-2.6.x/Documentation/DMA-API.txt
  drivers/net/*.c provides a lot of good examples for recent PCI
  devices.

o OsReadPciConfiguration
  Please see pci_resource_{start/len} and friends.

At this point, lnxosl.c will be removable and nobody will regret it.

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>