| To: | davem@xxxxxxxxxxxxx, jgarzik@xxxxxxxxx |
|---|---|
| Subject: | [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Sun, 9 Jan 2005 13:16:30 +0100 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
doing the actual work once it's been kill_proc()ed on module removal
time.
Based on debugging and an earlier patch that adds a driver-private
semaphore from Herbert Xu.
--- 1.101/drivers/net/8139too.c 2004-10-30 02:00:00 +02:00
+++ edited/drivers/net/8139too.c 2005-01-09 12:55:31 +01:00
@@ -1636,7 +1636,8 @@
if (tp->time_to_die)
break;
- rtnl_lock ();
+ if (rtnl_lock_interruptible ())
+ break;
rtl8139_thread_iter (dev, tp, tp->mmio_addr);
rtnl_unlock ();
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] add rtnl_lock_interruptible(), Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH] mark arcdev_setup static, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/2] add rtnl_lock_interruptible(), Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |