| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] sis900 debugging and revision code |
| From: | Daniele Venzano <webvenza@xxxxxxxxx> |
| Date: | Fri, 7 Jan 2005 12:58:32 +0100 |
| Cc: | NetDev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <41DDCB54.2080101@pobox.com> |
| Mail-followup-to: | Jeff Garzik <jgarzik@xxxxxxxxx>, NetDev <netdev@xxxxxxxxxxx> |
| References: | <20041212121852.GA16325@gateway.milesteg.arr> <20041212123031.GB16325@gateway.milesteg.arr> <41DDCB54.2080101@pobox.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, Jan 06, 2005 at 06:35:48PM -0500, Jeff Garzik wrote: > Patches 1, 2, and 5 are OK. > > For the other two patches, I don't want to deviate from the style that > has been standard for years: dev->name prefix, followed by message. > > It may make greps easier for you, but it becomes a non-standard style > and may make existing sysadmin scripts out in the field. > > Please resend series without the PFX-where-devname-is-known changes. Ok, I just don't have time to do it right now, but I'll rediff ASAP. However a message reformat patch will be needed because there are some messages that don't conform to either (mine or established) standard. Also I think I'll add at the end of the patchset a new patch that was sent recently on linux-kernel that adds support for netconsole. Bye. -- ----------------------------- Daniele Venzano Web: http://teg.homeunix.org |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] 1/5: eepro: cache EEPROM values, Aristeu Sergio Rozanski Filho |
|---|---|
| Next by Date: | [PATCH 2.4] Bugfix in neigh_create, Raivis Bucis |
| Previous by Thread: | Re: [PATCH 1/5] sis900 debugging and revision code, Jeff Garzik |
| Next by Thread: | [PATCH 4/28] net/cosa: replace schedule_timeout() with msleep(), Nishanth Aravamudan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |